Fix a lot of crashes with empty or single-letter inputs.

copycat/codeletMethods.py

@@ -267,6 +267,7 @@ def bottom_up_bond_scout(ctx, codelet):
     slipnet = ctx.slipnet
     workspace = ctx.workspace
     source = chooseUnmodifiedObject(ctx, 'intraStringSalience', workspace.objects)
+    assert source is not None
     __showWhichStringObjectIsFrom(source)
     destination = chooseNeighbor(ctx, source)
     assert destination
@@ -372,14 +373,13 @@ def replacement_finder(ctx, codelet):
     workspace = ctx.workspace
     # choose random letter in initial string
     letters = [o for o in workspace.initial.objects if isinstance(o, Letter)]
+    assert letters
     letterOfInitialString = random.choice(letters)
-    if letterOfInitialString.replacement:
+    assert not letterOfInitialString.replacement
-        return
     position = letterOfInitialString.leftIndex
     moreLetters = [o for o in workspace.modified.objects
                    if isinstance(o, Letter) and o.leftIndex == position]
-    if not moreLetters:
+    assert moreLetters
-        return
     letterOfModifiedString = moreLetters[0]
     initialAscii = ord(workspace.initialString[position - 1])
     modifiedAscii = ord(workspace.modifiedString[position - 1])
@@ -702,7 +702,8 @@ def group_scout__whole_string(ctx, codelet):
     workspace = ctx.workspace
     string = random.choice([workspace.initial, workspace.target])
     # find leftmost object & the highest group to which it belongs
-    leftmost = next(o for o in string.objects if o.leftmost)
+    leftmost = next((o for o in string.objects if o.leftmost), None)
+    assert leftmost is not None
     while leftmost.group and leftmost.group.bondCategory == slipnet.sameness:
         leftmost = leftmost.group
     if leftmost.spansString():
@@ -862,11 +863,10 @@ def rule_translator(ctx, codelet):
     temperature = ctx.temperature
     workspace = ctx.workspace
     assert workspace.rule
-    if len(workspace.initial) == 1 and len(workspace.target) == 1:
+    if len(workspace.initial) + len(workspace.target) <= 2:
         bondDensity = 1.0
     else:
-        numberOfBonds = (len(workspace.initial.bonds) +
+        numberOfBonds = len(workspace.initial.bonds) + len(workspace.target.bonds)
-                         len(workspace.target.bonds))
         nearlyTotalLength = len(workspace.initial) + len(workspace.target) - 2
         bondDensity = numberOfBonds / nearlyTotalLength
         bondDensity = min(bondDensity, 1.0)
@@ -887,8 +887,10 @@ def bottom_up_correspondence_scout(ctx, codelet):
     workspace = ctx.workspace
     objectFromInitial = chooseUnmodifiedObject(ctx, 'interStringSalience',
                                                workspace.initial.objects)
+    assert objectFromInitial is not None
     objectFromTarget = chooseUnmodifiedObject(ctx, 'interStringSalience',
                                               workspace.target.objects)
+    assert objectFromTarget is not None
     assert objectFromInitial.spansString() == objectFromTarget.spansString()
     # get the posible concept mappings
     conceptMappings = formulas.getMappings(
@@ -930,6 +932,7 @@ def important_object_correspondence_scout(ctx, codelet):
     workspace = ctx.workspace
     objectFromInitial = chooseUnmodifiedObject(ctx, 'relativeImportance',
                                                workspace.initial.objects)
+    assert objectFromInitial is not None
     descriptors = objectFromInitial.relevantDistinguishingDescriptors()
     # choose descriptor by conceptual depth
     weights = [temperature.getAdjustedValue(n.conceptualDepth) for n in descriptors]

copycat/coderack.py

@@ -259,14 +259,20 @@ class Coderack(object):
 
     def postInitialCodelets(self):
         workspace = self.ctx.workspace
-        logging.info("posting initial codelets")
+        n = len(workspace.objects)
-        codeletsToPost = [
+        if n == 0:
-            'bottom-up-bond-scout',
+            # The most pathological case.
-            'replacement-finder',
+            codeletsToPost = [
-            'bottom-up-correspondence-scout',
+                ('rule-scout', 1),
-        ]
+            ]
-        for name in codeletsToPost:
+        else:
-            for _ in xrange(2 * len(workspace.objects)):
+            codeletsToPost = [
+                ('bottom-up-bond-scout', 2 * n),
+                ('replacement-finder', 2 * n),
+                ('bottom-up-correspondence-scout', 2 * n),
+            ]
+        for name, count in codeletsToPost:
+            for _ in xrange(count):
                 codelet = Codelet(name, 1, [], self.codeletsRun)
                 self.post(codelet)
 

copycat/curses_reporter.py

@@ -370,7 +370,6 @@ class CursesReporter(Reporter):
 
         for string in [workspace.initial, workspace.modified, workspace.target]:
             row += 1
-            maxImportance = max(o.relativeImportance for o in group_and_letter_objects if o.string == string)
             letters_in_string = sorted(
                 (o for o in letter_objects if o.string == string),
                 key=lambda o: o.leftIndex,
@@ -379,6 +378,8 @@ class CursesReporter(Reporter):
                 (o for o in group_objects if o.string == string),
                 key=lambda o: o.leftIndex,
             )
+            if groups_in_string or letters_in_string:
+                maxImportance = max(o.relativeImportance for o in groups_in_string + letters_in_string)
             bonds_in_string = sorted(
                 (b for b in bond_structures if b.string == string),
                 key=lambda b: b.leftObject.rightIndex,

copycat/rule.py

@@ -26,7 +26,7 @@ class Rule(WorkspaceStructure):
     def updateInternalStrength(self):
         workspace = self.ctx.workspace
         if not (self.descriptor and self.relation):
-            self.internalStrength = 0.0
+            self.internalStrength = 50.0
             return
         averageDepth = (self.descriptor.conceptualDepth +
                         self.relation.conceptualDepth) / 2.0
@@ -121,6 +121,8 @@ class Rule(WorkspaceStructure):
 
     def buildTranslatedRule(self):
         workspace = self.ctx.workspace
+        if not (self.descriptor and self.relation):
+            return workspace.targetString
         slippages = workspace.slippages()
         self.category = self.category.applySlippages(slippages)
         self.facet = self.facet.applySlippages(slippages)